Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] make java worker log file prefix (default to java-worker) configurable #33787

Closed
jiafuzha opened this issue Mar 28, 2023 · 0 comments · Fixed by #33797
Closed

[Java] make java worker log file prefix (default to java-worker) configurable #33787

jiafuzha opened this issue Mar 28, 2023 · 0 comments · Fixed by #33797
Labels
enhancement Request for new feature and/or capability java P2 Important issue, but not time-critical

Comments

@jiafuzha
Copy link
Contributor

Description

For java worker, it's log file always being prefixed with "java-worker". And in python log_monitor.py, it hardcodes "java-worker*.log" to be polled for new log msg periodically. Some configs, like log_to_driver and RAY_BACKEND_LOG_LEVEL, don't prevent the log monitor from polling and publishing logs to gcs. To save some CPU cycle and network bandwidth, especially if there is large amount of logs produced from JVM, we can have an option. like a JVM system property, to set log file prefix for java worker instead of hard coded to "java-worker".

Use case

For RayDP, there are large number of INFO logs generated by Spark executor. The logs are useful but no need to be log-monitored by ray. We can rename ray java worker log file to be prefixed with something else other than 'java-worker'. Then, ray log monitor will not poll logs from the log files.

@jiafuzha jiafuzha added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Mar 28, 2023
@hora-anyscale hora-anyscale added java P2 Important issue, but not time-critical and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for new feature and/or capability java P2 Important issue, but not time-critical
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants