Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR output] Warnings for AIR_VERBOSITY is confusing #33810

Open
scottsun94 opened this issue Mar 28, 2023 · 3 comments
Open

[AIR output] Warnings for AIR_VERBOSITY is confusing #33810

scottsun94 opened this issue Mar 28, 2023 · 3 comments
Assignees
Labels
bug Something that is supposed to be working; but isn't P2 Important issue, but not time-critical ray-team-created Ray Team created tune Tune-related issues

Comments

@scottsun94
Copy link
Contributor

scottsun94 commented Mar 28, 2023

What happened + What you expected to happen

Confusing instructions. Not sure what the second half of it means.

2023-03-28 09:36:07,926 WARNING tune.py:526 -- Testing new AIR console output flow with verbosity=1. This will also disable the old flow - setting it to 0 now.

Can we change it to something like
2023-03-28 09:36:07,926 WARNING tune.py:526 -- AIR_VERBOSITY is set to 1 and new AIR console output is enabled. To see the old console output, don't use or unset AIR_VERBOSITY.

Versions / Dependencies

Nightly

Reproduction script

n/a

Issue Severity

Low: It annoys or frustrates me.

@scottsun94 scottsun94 added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Mar 28, 2023
@xwjiang2010 xwjiang2010 added this to the Tune Console Output milestone Mar 28, 2023
@xwjiang2010 xwjiang2010 added P2 Important issue, but not time-critical air and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Mar 28, 2023
@xwjiang2010
Copy link
Contributor

  • time_this_iter vs time_total_s
    time_total_s means "Accumulated time in seconds for this entire trial."
    time_this_iter is just for this past iteration.

  • "running for 00:00:18:09" captures the entire running time (from the beginning when you say xx.fit()).

  • You should see checkpoint information, if it is saved. But whether to save it is a user call. Can you first make sure that checkpoint saving is turned on for every iteration? If it's off, we won't print that line for the iteration.

@xwjiang2010
Copy link
Contributor

  • "Configurations for TorchTrainer: "
    what should we say if there is no specified configuration for starting the trainer (a lot of times the case)?

Right now, I make it
"started with configuration {...}" v.s. "started".

@scottsun94
Copy link
Contributor Author

  • time_this_iter vs time_total_s
    time_total_s means "Accumulated time in seconds for this entire trial."
    time_this_iter is just for this past iteration.
  • "running for 00:00:18:09" captures the entire running time (from the beginning when you say xx.fit()).
  • You should see checkpoint information, if it is saved. But whether to save it is a user call. Can you first make sure that checkpoint saving is turned on for every iteration? If it's off, we won't print that line for the iteration.

Got it. Thanks! We can do something like this then?

  • Training time of this iteration == time_this_iter
  • Total running time == time_total_s at the end of last iteration
  • Total training time == sum of all iterations' time_this_iter?
Iteration 4 finished at 2023-03-28 10:09:42. Training time of this iteration: 8.96s
-------------------------
loss             2.24726
-------------------------
Checkpoint saved at: mnt/ray_result/...

Training finished (4 iterations) at 2023-02-24 12:35:39. Total training time: 39.68s. Total running time: 46.97s
Last checkpoint saved at: mnt/ray_result/...

@matthewdeng matthewdeng added the ray-team-created Ray Team created label Apr 3, 2023
@xwjiang2010 xwjiang2010 assigned gjoliver and unassigned xwjiang2010 Apr 20, 2023
@scottsun94 scottsun94 assigned krfricke and unassigned gjoliver May 1, 2023
@scottsun94 scottsun94 changed the title [AIR output] UX issues of new AIR output for train [AIR output] Warnings for AIR_VERBOSITY is confusing May 1, 2023
@anyscalesam anyscalesam added tune Tune-related issues and removed air labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't P2 Important issue, but not time-critical ray-team-created Ray Team created tune Tune-related issues
Projects
None yet
Development

No branches or pull requests

6 participants