Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] Remove acquire_reader_lock flag in replica #37209

Closed
edoakes opened this issue Jul 7, 2023 · 2 comments
Closed

[serve] Remove acquire_reader_lock flag in replica #37209

edoakes opened this issue Jul 7, 2023 · 2 comments
Assignees
@edoakes @rkooo567
Labels
bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks serve Ray Serve Related Issue

Comments

@edoakes
Copy link
Contributor

edoakes commented Jul 7, 2023

In #37114, I had to add a flag to skip grabbing the lock in the user-provided generator codepath due to #37147.

Once that fix for that issue is merged, we need to remove the flag and always grab the lock.
@edoakes edoakes added bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks serve Ray Serve Related Issue labels Jul 7, 2023
@edoakes edoakes self-assigned this Jul 7, 2023
@edoakes
Copy link
Contributor Author

edoakes commented Jul 24, 2023

Should be closed by #37713

@rkooo567
Copy link
Contributor

rkooo567 commented Aug 7, 2023

This is fixed

@rkooo567 rkooo567 closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edoakes edoakes

@rkooo567 rkooo567

Labels
bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks serve Ray Serve Related Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edoakes @rkooo567