You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is expected #37972 causes some level of perf issue. But it seems like this actually impacts Aviary. @Yard1 will double verify this Monday if this is true.
To fix the issue, we should
post the cpp level code to a thread pool. Previously, we called cpp code that doesn't hold GIL inside a main thread, so event loop thread could focus on running python code. Now, we are running the cpp code inside the event loop, so nogil doesn't have much impact anymore (because there's no concurrency).
Start running microbenchmark that could catch regressions. (@edoakes is it also possible to start tracking serve microbenchmark separately? )
Versions / Dependencies
master
Reproduction script
n/a
Issue Severity
None
The text was updated successfully, but these errors were encountered:
rkooo567
added
bug
Something that is supposed to be working; but isn't
P0
Issues that should be fixed in short order
core
Issues that should be addressed in Ray Core
labels
Aug 7, 2023
What happened + What you expected to happen
It is expected #37972 causes some level of perf issue. But it seems like this actually impacts Aviary. @Yard1 will double verify this Monday if this is true.
To fix the issue, we should
Versions / Dependencies
master
Reproduction script
n/a
Issue Severity
None
The text was updated successfully, but these errors were encountered: