Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Ray Dashboard goes blank when moving to the "Actor" tab of the "Node Detail" page #42460

Closed
ckw017 opened this issue Jan 17, 2024 · 6 comments
Assignees
Labels
bug Something that is supposed to be working; but isn't dashboard Issues specific to the Ray Dashboard P1 Issue that should be fixed within a few weeks

Comments

@ckw017
Copy link
Member

ckw017 commented Jan 17, 2024

What happened + What you expected to happen

Seeing this in the console

react-dom.production.min.js:216 TypeError: Cannot read properties of undefined (reading 'ipAddress')
at ActorTable.tsx:384:68
at Array.filter ()
at ActorTable.tsx:381:29
at Array.map ()
at t.Z (ActorTable.tsx:362:19)
at oo (react-dom.production.min.js:157:137)
at Ws (react-dom.production.min.js:267:460)
at Al (react-dom.production.min.js:250:347)
at Ol (react-dom.production.min.js:250:278)
at xl (react-dom.production.min.js:250:138)
us @ react-dom.production.min.js:216
n.callback @ react-dom.production.min.js:216
mi @ react-dom.production.min.js:131
hs @ react-dom.production.min.js:220
Ml @ react-dom.production.min.js:259
t.unstable_runWithPriority @ scheduler.production.min.js:18
Va @ react-dom.production.min.js:122
Dl @ react-dom.production.min.js:252
bl @ react-dom.production.min.js:243
(anonymous) @ react-dom.production.min.js:123
t.unstable_runWithPriority @ scheduler.production.min.js:18
Va @ react-dom.production.min.js:122
$a @ react-dom.production.min.js:123
Wa @ react-dom.production.min.js:122
Le @ react-dom.production.min.js:292
Kt @ react-dom.production.min.js:73
Show 16 more frames
Show less
ActorTable.tsx:384 Uncaught TypeError: Cannot read properties of undefined (reading 'ipAddress')
at ActorTable.tsx:384:68
at Array.filter ()
at ActorTable.tsx:381:29
at Array.map ()
at t.Z (ActorTable.tsx:362:19)
at oo (react-dom.production.min.js:157:137)
at Ws (react-dom.production.min.js:267:460)
at Al (react-dom.production.min.js:250:347)
at Ol (react-dom.production.min.js:250:278)
at xl (react-dom.production.min.js:250:138)

Versions / Dependencies

ray 2.9.0

Reproduction script

Issue Severity

Low: It annoys or frustrates me.

@ckw017 ckw017 added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jan 17, 2024
@anyscalesam anyscalesam added the dashboard Issues specific to the Ray Dashboard label Jan 17, 2024
@scottsun94 scottsun94 added P0 Issues that should be fixed in short order and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jan 23, 2024
@scottsun94
Copy link
Contributor

Image

Image

@ckw017 Is there a way to reproduce this. Cannot reproduce on my side.

@scottsun94 scottsun94 added P1 Issue that should be fixed within a few weeks and removed P0 Issues that should be fixed in short order labels Jan 23, 2024
@scottsun94
Copy link
Contributor

ActorTable.tsx:384 Uncaught TypeError: Cannot read properties of undefined (reading 'ipAddress')

@alanwguo Can you take a look?

@ckw017
Copy link
Member Author

ckw017 commented Jan 24, 2024

Can only repro when looking at nodes with dead actors on them. I have a repro on an internal cluster, feel free to dm for details

@nikitavemuri
Copy link
Contributor

This was probably fixed by #42788 and confirmed the node detail page works with dead actors
Screen Shot 2024-02-01 at 3 08 56 PM

@ckw017 could you check if this is fixed in your repro also?

@ckw017
Copy link
Member Author

ckw017 commented Feb 1, 2024

Tricky to upgrade the cluster I repro'd with onto nightly, but if this fixed a problem with the same symptoms (can't load the page when there's a dead actor on it) then was likely the same issue.

@nikitavemuri nikitavemuri self-assigned this Feb 1, 2024
@nikitavemuri
Copy link
Contributor

Closing because this seems to be fixed on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't dashboard Issues specific to the Ray Dashboard P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

No branches or pull requests

4 participants