Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Important Module Removed] internal.cc/internal.h had been remove, but it's related to mobius. #44065

Closed
ashione opened this issue Mar 16, 2024 · 2 comments · Fixed by #44066
Closed
Labels
bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@ashione
Copy link
Member

ashione commented Mar 16, 2024

What happened + What you expected to happen

I'm just working in building new mobius version(with ray lastest 2.9.3) ray-project/mobius#60 . But found internal.cc/internal.h and exported_internal has been removed in this PR #34697.

I want to know why these files need to be deleted?
Actually thridparty system(based ray core libraries) would better to integrate core worker functions without innner symbols races. So in that time, we create this module for making sure other module can accessing rpc etc. interface by actor handler.

Versions / Dependencies

2.5

Reproduction script

No need script

Issue Severity

None

@ashione ashione added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Mar 16, 2024
@ashione
Copy link
Member Author

ashione commented Mar 16, 2024

@fishbone @rkooo567 plz take a look this issue.

@ashione
Copy link
Member Author

ashione commented Mar 16, 2024

#44066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant