Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in example tune_tensorflow_autoencoder_example.py #46505

Closed
mjovanovic9999 opened this issue Jul 9, 2024 · 1 comment · Fixed by #46565
Closed

Error in example tune_tensorflow_autoencoder_example.py #46505

mjovanovic9999 opened this issue Jul 9, 2024 · 1 comment · Fixed by #46565
Assignees
Labels
bug Something that is supposed to be working; but isn't docs An issue or change related to documentation P2 Important issue, but not time-critical train Ray Train Related Issue

Comments

@mjovanovic9999
Copy link
Contributor

What happened + What you expected to happen

I was trying to run the basic example https://github.com/ray-project/ray/blob/master/python/ray/train/examples/tf/tune_tensorflow_autoencoder_example.py

Gave me this error:

ValueError: scaling_config should be an instance of ScalingConfig, found <class 'dict'> with value {'num_workers': 2, 'use_gpu': False}.

This chage soloved the issue:

scaling_config = dict(num_workers=num_workers, use_gpu=use_gpu)

to:

from ray.train import ScalingConfig
...
scaling_config = ScalingConfig(num_workers=num_workers, use_gpu=use_gpu)

Versions / Dependencies

ray, version 2.31.0
Python 3.9.19
Official docker image rayproject/ray

Reproduction script

python tune_tensorflow_autoencoder_example.py

Issue Severity

Medium: It is a significant difficulty but I can work around it.

@mjovanovic9999 mjovanovic9999 added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jul 9, 2024
@anyscalesam
Copy link
Contributor

@mjovanovic9999 thanks for the find; can you submit a PR to fix the example in our docs? Assign to me as reviewer and I'll shepherd it through.

@anyscalesam anyscalesam added P2 Important issue, but not time-critical docs An issue or change related to documentation train Ray Train Related Issue and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't docs An issue or change related to documentation P2 Important issue, but not time-critical train Ray Train Related Issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants