-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ray doesn't build on Ubuntu 19.10 due to GRPC #5984
Comments
@mawright Thanks for the report! It is failing to compile grpc, can you try to replace this line here: and the line two below to the latest release commit |
Hi Phillip, I was digging around and it looks like you were right about it being a bug in grpc. It looks like that bug was fixed in this commit: grpc/grpc@57586a1 Unfortunately when I updated the link to the grpc artifact like you said, http_archive(
name = "com_github_grpc_grpc",
urls = [
"https://github.com/grpc/grpc/archive/2de2e8dd8921e1f7d043e01faf7fe8a291fbb072.tar.gz"
],
strip_prefix = "grpc-2de2e8dd8921e1f7d043e01faf7fe8a291fbb072",
) I got a new error:
|
Thanks for trying it out! This seems to be a new issue that is fixed in grpc/grpc#20586, however with that PR I get another error:
Is it possible for you to use ubuntu 18 in the meantime while this gets fixed? |
Did you call grpc_extra_deps() introduced in grpc/grpc#20586 from somewhere here? |
I am only doing development on Python stuff so I think I will be able to work around it by installing from the wheel and symlinking stuff. |
@gallmerci Thanks for your help! I tried what you suggested (in #6002) and now I get the following error:
So it looks like |
@pcmoritz you need to execute grpc_deps() before you load grpc_extra_deps.bzl because the repos are defined after calling grpc_deps()
|
@gallmerci That indeed fixes the problem, thank you so much for your help. I updated the PR. |
System information
34fbc7f
Describe the problem
Source code / logs
The text was updated successfully, but these errors were encountered: