From acb799575e1a93ec05b1a5bf303901adb7a0f9e4 Mon Sep 17 00:00:00 2001 From: avnishn Date: Fri, 18 Mar 2022 22:40:36 -0700 Subject: [PATCH 1/6] Pin gym everywhere --- python/requirements/ml/requirements_tune.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/requirements/ml/requirements_tune.txt b/python/requirements/ml/requirements_tune.txt index fbee10ee0c1e..c19669e5416e 100644 --- a/python/requirements/ml/requirements_tune.txt +++ b/python/requirements/ml/requirements_tune.txt @@ -11,7 +11,7 @@ freezegun==1.1.0 gluoncv==0.10.1.post0 gpy==1.10.0 autorom[accept-rom-license] -gym[atari]>=0.21.0; python_version >= '3.7' +gym[atari]>=0.21.0,<0.22.0; python_version >= '3.7' gym[atari]==0.19.0; python_version < '3.7' h5py==3.1.0 hpbandster==0.7.4 From 3f3ce2ba8aed4043fafe149cc1cb77c769c977bf Mon Sep 17 00:00:00 2001 From: avnishn Date: Fri, 18 Mar 2022 22:49:46 -0700 Subject: [PATCH 2/6] Add it for missing occurances in release tests --- ci/asan_tests/ray-project/requirements.txt | 2 +- release/long_running_tests/app_config.yaml | 4 ++-- release/long_running_tests/app_config_np.yaml | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ci/asan_tests/ray-project/requirements.txt b/ci/asan_tests/ray-project/requirements.txt index 604e24b586bd..935c22901352 100644 --- a/ci/asan_tests/ray-project/requirements.txt +++ b/ci/asan_tests/ray-project/requirements.txt @@ -9,7 +9,7 @@ feather-format flask frozenlist grpcio >= 1.28.1, <= 1.43.0 -gym +gym==0.21 kubernetes lxml networkx diff --git a/release/long_running_tests/app_config.yaml b/release/long_running_tests/app_config.yaml index af8e396e601e..00f09b53b858 100755 --- a/release/long_running_tests/app_config.yaml +++ b/release/long_running_tests/app_config.yaml @@ -7,7 +7,7 @@ debian_packages: python: pip_packages: - - gym[atari] + - gym[atari]==0.21.0 - pytest - tensorflow conda_packages: [] @@ -15,7 +15,7 @@ python: post_build_cmds: - 'rm -r wrk || true && git clone https://github.com/wg/wrk.git /tmp/wrk && cd /tmp/wrk && make -j && sudo cp wrk /usr/local/bin' - pip3 install pytest || true - - pip3 install -U ray[all] gym[atari] autorom[accept-rom-license] + - pip3 install -U ray[all] gym[atari]==0.21.0 autorom[accept-rom-license] - pip3 install ray[all] # TODO (Alex): Ideally we would install all the dependencies from the new # version too, but pip won't be able to find the new version of ray-cpp. diff --git a/release/long_running_tests/app_config_np.yaml b/release/long_running_tests/app_config_np.yaml index 8f0ef429a00e..9c3dce9747b9 100644 --- a/release/long_running_tests/app_config_np.yaml +++ b/release/long_running_tests/app_config_np.yaml @@ -7,7 +7,7 @@ debian_packages: python: pip_packages: - - gym[atari] + - gym[atari]==0.21.0 - pygame - pytest - tensorflow @@ -18,7 +18,7 @@ post_build_cmds: - 'rm -r wrk || true && git clone https://github.com/wg/wrk.git /tmp/wrk && cd /tmp/wrk && make -j && sudo cp wrk /usr/local/bin' - pip3 install numpy==1.19 || true - pip3 install pytest || true - - pip3 install -U ray[all] gym[atari] autorom[accept-rom-license] + - pip3 install -U ray[all] gym[atari]==0.21.0 autorom[accept-rom-license] - pip3 install ray[all] # TODO (Alex): Ideally we would install all the dependencies from the new # version too, but pip won't be able to find the new version of ray-cpp. From 4143675d706245d5ceeb8cc583258f5f2aad18f7 Mon Sep 17 00:00:00 2001 From: avnishn Date: Mon, 21 Mar 2022 12:48:24 -0700 Subject: [PATCH 3/6] Pin gym in app config --- release/rllib_tests/app_config.yaml | 3 ++- release/tune_tests/cloud_tests/app_config.yaml | 1 + release/tune_tests/cloud_tests/app_config_ml.yaml | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/release/rllib_tests/app_config.yaml b/release/rllib_tests/app_config.yaml index 5029c76d1ae0..aefe5e0253b8 100755 --- a/release/rllib_tests/app_config.yaml +++ b/release/rllib_tests/app_config.yaml @@ -7,7 +7,8 @@ debian_packages: python: # These dependencies should be handled by requirements_rllib.txt and # requirements_ml_docker.txt - pip_packages: [] + pip_packages: + - gym==0.21.0 conda_packages: [] post_build_cmds: diff --git a/release/tune_tests/cloud_tests/app_config.yaml b/release/tune_tests/cloud_tests/app_config.yaml index e1075af1b636..73dc7ab98ad3 100755 --- a/release/tune_tests/cloud_tests/app_config.yaml +++ b/release/tune_tests/cloud_tests/app_config.yaml @@ -8,6 +8,7 @@ python: - pytest - awscli - gsutil + - gym==0.21.0 conda_packages: [] post_build_cmds: diff --git a/release/tune_tests/cloud_tests/app_config_ml.yaml b/release/tune_tests/cloud_tests/app_config_ml.yaml index 2c16265b674c..bf31dff98207 100755 --- a/release/tune_tests/cloud_tests/app_config_ml.yaml +++ b/release/tune_tests/cloud_tests/app_config_ml.yaml @@ -8,6 +8,7 @@ python: - pytest - awscli - gsutil + - gym==0.21.0 conda_packages: [] post_build_cmds: From be5b5076ad8b1314714cc6bcba87f772e14a7b97 Mon Sep 17 00:00:00 2001 From: avnishn Date: Wed, 23 Mar 2022 19:33:57 -0700 Subject: [PATCH 4/6] Pin for PBT tests --- release/long_running_distributed_tests/app_config.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/release/long_running_distributed_tests/app_config.yaml b/release/long_running_distributed_tests/app_config.yaml index 3eb08803088c..59e1fd010ef8 100644 --- a/release/long_running_distributed_tests/app_config.yaml +++ b/release/long_running_distributed_tests/app_config.yaml @@ -7,6 +7,7 @@ python: pip_packages: - pytest - awscli + - gym==0.21.0 conda_packages: [] post_build_cmds: From 1c843b6001232d3b998d1ff55a6cbb48d8746487 Mon Sep 17 00:00:00 2001 From: avnishn Date: Wed, 23 Mar 2022 21:07:16 -0700 Subject: [PATCH 5/6] Switch framework back to tf, torch gpu broken --- release/rllib_tests/learning_tests/hard_learning_tests.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release/rllib_tests/learning_tests/hard_learning_tests.yaml b/release/rllib_tests/learning_tests/hard_learning_tests.yaml index fac6d307d5ca..32951096d8ec 100644 --- a/release/rllib_tests/learning_tests/hard_learning_tests.yaml +++ b/release/rllib_tests/learning_tests/hard_learning_tests.yaml @@ -472,7 +472,7 @@ slateq-interest-evolution-recsim-env: # test for now, we'll use pytorch, and investigate why tensorflow is not working. # One indication of the issue is that the loss inputs are not flattened from the # original dictionary spaces. - framework: torch + framework: tf # Each step, sample `num_candidates` documents using the env-internal # document sampler model (a logic that creates n documents to select # the slate from). From 029a31d0951f07d3ae9d85b0f7cd2ea00bb4282b Mon Sep 17 00:00:00 2001 From: avnishn Date: Wed, 23 Mar 2022 21:10:12 -0700 Subject: [PATCH 6/6] turn gpu off for now --- release/rllib_tests/learning_tests/hard_learning_tests.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release/rllib_tests/learning_tests/hard_learning_tests.yaml b/release/rllib_tests/learning_tests/hard_learning_tests.yaml index 32951096d8ec..2277ab364520 100644 --- a/release/rllib_tests/learning_tests/hard_learning_tests.yaml +++ b/release/rllib_tests/learning_tests/hard_learning_tests.yaml @@ -487,7 +487,7 @@ slateq-interest-evolution-recsim-env: convert_to_discrete_action_space: false seed: 0 - num_gpus: 1 + num_gpus: 0 exploration_config: warmup_timesteps: 20000