[Keyboard Brightness] Error toast appears even when toggle is successful

[clasick]

Extension

https://www.raycast.com/huzef44/keyboard-brightness

Description

When using the "Toggle Keyboard Brightness" action, the error toast "Failed Toggling Keyboard Brightness" appears even when the toggle is successful, i.e., the keyboard lights turn on/off as desired.

Steps To Reproduce

1. Install the Keyboard Brightness extension
2. Open Raycast
3. Find and run the Toggle Keyboard Brightness command
4. Observe the physical keyboard lights are toggled from on to off, or off to on
5. Observe error toast appear in the bottom middle of the screen: "Failed Toggling Keyboard Brightness"

Current Behaviour

Error toast appears when toggle is successful

Expected Behaviour

Error toast should only be shown during toggle failure

[raycastbot]

Thank you for opening this issue!

🔔 @neo773 @belyakov-am @DannySeidel @pernielsentikaer you might want to have a look.

💡 Author and Contributors commands

The author and contributors of huzef44/keyboard-brightness can trigger bot actions by commenting:

• @raycastbot close this issue Closes the issue.
• @raycastbot rename this issue to "Awesome new title" Renames the issue.
• @raycastbot reopen this issue Reopen the issue.

[DannySeidel]

I tried out different commits to see when the error first appeared and it seems that the error was introduced in commit 33d4d2d by @pernielsentikaer in PR #11740. With the previous commits the error isn't triggered.

@pernielsentikaer what was the purpose of the changes in the commit? Because the Menubar extension and the alerts seem to be in sync.

[pernielsentikaer]

I added a fix here for it @DannySeidel

[pernielsentikaer]

Should be fixed now, thanks for flagging