-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notion] Major(ish) refactoring (pt. 2) #14215
base: main
Are you sure you want to change the base?
Conversation
Readable makes more sense, as 'formula' isn't a writable type. Union type names should be singular.
* 🏷️ Remove `name` from `DatabaseView` The `name` field wasn't being used. The value of `database.title` was saved into local storage, then read back out and used in replace of `database.title`. * ♻️ Use `useChachedState` for kanban config * 🗃️ Convert old kanban config to Cache * 🐛 Fix wierd cache issues in search * 🚸 Hide `title` from property visibility list * ⚡️ Run `convertDepreciatedViewConfig` fewer times * ♻️ Use `useChachedState` for view config * 🗃️ Convert old view config to Cache
Thank you for your contribution! 🎉 🔔 @HenriChabrand @mathieudutour @metakirby5 @thomaslombart @erics118 @AlexIsMaking @Yakitrak @tleo19 @dariuszpaluch @zsidnam you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. Due to our current reduced availability, the initial review may take up to 10-15 business days. |
This reverts commit f23e1cc.
This pull request has been automatically marked as stale because it did not have any recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊 |
This PR is still waiting on #13955 |
The `useConvertDepreciatedViewConfig` hook was causing `useDatabaseProperties` to rerun at odd times and return an empty array.
This pull request has been automatically marked as stale because it did not have any recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊 |
|
This pull request has been automatically marked as stale because it did not have any recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊 |
Keeping PR draft open |
Description
Part 2 deals with refactoring the following:
DatabaseKanbanView
(ada963e)