Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notion] Major(ish) refactoring (pt. 2) #14215

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

bkeys818
Copy link
Contributor

@bkeys818 bkeys818 commented Aug 27, 2024

Description

This PR builds on top of #13955

Part 2 deals with refactoring the following:

Readable makes more sense, as 'formula' isn't a writable type.

Union type names should be singular.
* 🏷️ Remove `name` from `DatabaseView`

The `name` field wasn't being used. The value of `database.title` was
saved into local storage, then read back out and used in replace of
`database.title`.

* ♻️ Use `useChachedState` for kanban config

* 🗃️ Convert old kanban config to Cache

* 🐛 Fix wierd cache issues in search

* 🚸 Hide `title` from property visibility list

* ⚡️ Run `convertDepreciatedViewConfig` fewer times

* ♻️ Use `useChachedState` for view config

* 🗃️ Convert old view config to Cache
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: notion Issues related to the notion extension OP is contributor The OP of the PR is a contributor of the extension labels Aug 27, 2024
@raycastbot
Copy link
Collaborator

raycastbot commented Aug 27, 2024

Thank you for your contribution! 🎉

🔔 @HenriChabrand @mathieudutour @metakirby5 @thomaslombart @erics118 @AlexIsMaking @Yakitrak @tleo19 @dariuszpaluch @zsidnam you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days.

@raycastbot
Copy link
Collaborator

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Sep 15, 2024
@bkeys818
Copy link
Contributor Author

This PR is still waiting on #13955

@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Sep 18, 2024
The `useConvertDepreciatedViewConfig` hook was causing
`useDatabaseProperties` to rerun at odd times and return an empty array.
@raycastbot
Copy link
Collaborator

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Oct 7, 2024
@bkeys818
Copy link
Contributor Author

bkeys818 commented Oct 7, 2024

This PR is still waiting on #13955

@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Oct 7, 2024
@raycastbot
Copy link
Collaborator

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Oct 23, 2024
@bkeys818
Copy link
Contributor Author

Keeping PR draft open

@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: notion Issues related to the notion extension OP is contributor The OP of the PR is a contributor of the extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants