Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate config SINK_HTTP_PARAMETER_SCHEMA_PROTO_CLASS #143

Open
Meghajit opened this issue Nov 27, 2021 · 0 comments
Open

Deprecate config SINK_HTTP_PARAMETER_SCHEMA_PROTO_CLASS #143

Meghajit opened this issue Nov 27, 2021 · 0 comments

Comments

@Meghajit
Copy link
Member

Meghajit commented Nov 27, 2021

WHAT ?

Deprecate config SINK_HTTP_PARAMETER_SCHEMA_PROTO_CLASS

WHY ?

For a Firehose with HTTP Sink configured with header or query parameter source ( that is, SINK_HTTP_PARAMETER_SOURCE != disabled), the proto class that is used for parsing the incoming Kafka message during request creation is configured using SINK_HTTP_PARAMETER_SCHEMA_PROTO_CLASS.

This is confusing, as there is already a config INPUT_SCHEMA_PROTO_CLASS which tells the proto class that needs to be used for parsing the incoming Kafka message.

Ideally, we would like to keep a single variable which denotes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant