Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In GetEpoch(), uint64 needs to be removed #844

Closed
ashish10677 opened this issue Jul 18, 2022 · 0 comments · Fixed by #858
Closed

In GetEpoch(), uint64 needs to be removed #844

ashish10677 opened this issue Jul 18, 2022 · 0 comments · Fixed by #858
Milestone
v1.0.6

Comments

@ashish10677
Copy link
Member

uint64 is redundant in
https://github.com/razor-network/razor-go/blob/c199ec663ddcf872daab3caab8b81302e959d11b/utils/common.go#L147
since, latestHeader.Time is already a uint64 value
@shyam-patel-kira shyam-patel-kira mentioned this issue Jul 20, 2022
Merged
@shyam-patel-kira shyam-patel-kira linked a pull request Jul 20, 2022 that will close this issue
remove redundant uint64 typecast #858
Merged
@SkandaBhat SkandaBhat removed the v1 label Jul 20, 2022
@shekhar2807 shekhar2807 mentioned this issue Jul 26, 2022
Merged
@Yashk767 Yashk767 reopened this Oct 19, 2022
@Yashk767 Yashk767 mentioned this issue Oct 19, 2022
Closed
5 tasks
@Yashk767 Yashk767 added this to the v1.0.6 milestone Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.6
Development

Successfully merging a pull request may close this issue.

remove redundant uint64 typecast
4 participants
@SkandaBhat @ashish10677 @shyam-patel-kira @Yashk767