Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check reward before calling the claimStakerReward function in claimCommission command #908

Closed
ashish10677 opened this issue Aug 31, 2022 · 0 comments · Fixed by #926
Closed

Check reward before calling the claimStakerReward function in claimCommission command #908

ashish10677 opened this issue Aug 31, 2022 · 0 comments · Fixed by #926
Assignees
@shyam-patel-kira
Labels
bug Something isn't working
Milestone
v1.3.0-alpha

Comments

@ashish10677
Copy link
Member

System information

  • OS & Version: Linux
  • Go version: go 1.17
  • razor-go version: v1-mainnet-stable

Describe the bug

claimCommission command can be called by anyone, and it calls the claimStakerReward function of the smart contract without checking if the staker actually has accommodated any commission.

Expected behaviour

The smart contract call must not be made if there is no commission to claim.

Actual behaviour

The smart contract call is made regardless of whether the commission is there to claim or not.

Backtrace

er
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shyam-patel-kira shyam-patel-kira

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.3.0-alpha
Development

Successfully merging a pull request may close this issue.

Call claimStakerReward only if there reward to claim shyam-patel-kira/razor-go
4 participants
@SkandaBhat @ashish10677 @shyam-patel-kira @Yashk767