Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider "initial" or similar as the default background color #111

Open
sasmith opened this issue Apr 4, 2024 · 1 comment
Open

Consider "initial" or similar as the default background color #111

sasmith opened this issue Apr 4, 2024 · 1 comment

Comments

@sasmith
Copy link

sasmith commented Apr 4, 2024

The current default background color is black. For folks using dark mode, this seems reasonable enough. For folks using light mode, this isn't a great default. Having a default that more matches the concept of default should support both groups well. E.g., "initial" or "transparent" (and "initial" could work well for foreground colors as well).

Lmk if you'd like a PR, or if you want to leave as is for backwards compatibility.

@kentcdodds
Copy link

This is how I solve this. Seems to work quite well:

new AnsiToHTML(
	theme === 'dark'
		? { fg: '#d6deeb', bg: '#121318', escapeXML: true }
		: { fg: '#000000', bg: '#f3f3f3', escapeXML: true },
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants