Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pysnow.oauth_client.OAuthClient.resource should allow to pass request parameters (e.g. timeout) the same way pysnow.client.Client.resource does #200

Open
nkaraliova-godaddy opened this issue Jul 12, 2024 · 0 comments

Comments

@nkaraliova-godaddy
Copy link

nkaraliova-godaddy commented Jul 12, 2024

When using OauthClient, there is currently no way to overwrite the default 60 second timeout due to resource method signature of pysnow.oauth_client.OAuthClient not allowing to pass arbitrary kwargs.

# from pysnow.client.Client - resource signature:
def resource(self, api_path=None, base_path="/api/now", chunk_size=None, **kwargs)

# from pysnow.oauth_cleint.OAuthClient - resource signature:
def resource(self, api_path=None, base_path="/api/now", chunk_size=None)

Suggested fix: https://github.com/rbw/pysnow/pull/199/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant