Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: fix backpressure on readables #399

Merged
merged 2 commits into from
Jul 29, 2024
Merged

perf: fix backpressure on readables #399

merged 2 commits into from
Jul 29, 2024

Conversation

jeswr
Copy link
Collaborator

@jeswr jeswr commented Jul 29, 2024

Fixes backpressure issues on Readables; currently when streams are used, the entire dataset is put into the buffer before the stream starts emitting elements.

Copy link
Member

@RubenVerborgh RubenVerborgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, yeah that wasn't good!

@jeswr jeswr enabled auto-merge (squash) July 29, 2024 22:25
@jeswr jeswr merged commit f228aea into main Jul 29, 2024
13 checks passed
@jeswr jeswr deleted the perf/fix-backpressure branch July 29, 2024 22:25
Copy link

🎉 This PR is included in version 1.17.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants