Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance: perform dataset operations directly on index #400

Open
jeswr opened this issue Jul 29, 2024 · 3 comments
Open

performance: perform dataset operations directly on index #400

jeswr opened this issue Jul 29, 2024 · 3 comments

Comments

@jeswr
Copy link
Collaborator

jeswr commented Jul 29, 2024

There is lots of room for optimisation in methods such as union and difference; in particular, whenever other is also an N3Store and they share an index we can just merge / diff / compare the indices for set operations.

See #392
@jeswr jeswr changed the title performance: perform dataset operastions directly over index performance: perform dataset operations directly on index Jul 29, 2024
@jeswr jeswr mentioned this issue Jul 30, 2024
Merged
@jeswr
Copy link
Collaborator Author

jeswr commented Jul 30, 2024

Many functions would benefit from using #structuredClone in their implementation. However, this would require an mver bump to deprecate old versions of Node as #structuredClone is only available from Node v17

@RubenVerborgh
Copy link
Member

And browser? Maybe good to use it conditionally for now.

@jeswr
Copy link
Collaborator Author

jeswr commented Jul 30, 2024

Seems to be supported across all browsers now https://developer.mozilla.org/en-US/docs/Web/API/structuredClone#browser_compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RubenVerborgh @jeswr