Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: be selective over which index to use first for indexMatch #444

Closed
jeswr opened this issue Sep 8, 2024 · 1 comment
Closed

perf: be selective over which index to use first for indexMatch #444

jeswr opened this issue Sep 8, 2024 · 1 comment

Comments

@jeswr
Copy link
Collaborator

jeswr commented Sep 8, 2024

We could optimise slightly further by using the same technique as #readQuads to determine which index to match over first as this will be more efficient for identifying if there are no matches. But it would be sufficient to leave that work for a follow up PR.

See #443 (comment).
@coderabbitai coderabbitai bot mentioned this issue Sep 17, 2024
Merged
@jeswr
Copy link
Collaborator Author

jeswr commented Sep 27, 2024

Completed in #443

@jeswr jeswr closed this as completed Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeswr