From ed5714eab87e775b9bbd6bbedfc3858c14a76bd7 Mon Sep 17 00:00:00 2001
From: Matthieu Bosquet <matthieubosquet@gmail.com>
Date: Mon, 9 Sep 2024 17:01:51 +0100
Subject: [PATCH] Add missing spec methods to DataFactory interface

---
 CHANGELOG.md    |  6 ++++++
 data-model.d.ts | 14 ++++++++++++++
 rdf-js-tests.ts | 21 +++++++++++++++++++++
 3 files changed, 41 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 185805f..9531742 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @rdfjs/types
 
+## 1.1.1
+
+### Minor Changes
+
+- Add missing methods to DataFactory interface
+
 ## 1.1.0
 
 ### Minor Changes
diff --git a/data-model.d.ts b/data-model.d.ts
index 6fff406..8f7f80b 100644
--- a/data-model.d.ts
+++ b/data-model.d.ts
@@ -287,4 +287,18 @@ export interface DataFactory<OutQuad extends BaseQuad = Quad, InQuad extends Bas
      * @see Quad
      */
     quad(subject: InQuad['subject'], predicate: InQuad['predicate'], object: InQuad['object'], graph?: InQuad['graph']): OutQuad;
+
+    /**
+     * @param original The original term.
+     * @return A new instance of the term such that newTermInstance.equals(original) returns true.
+     * @see Term
+     */
+    fromTerm(original: Term): Term;
+
+    /**
+     * @param original The original quad.
+     * @return A new instance of the quad such that newQuadInstance.equals(original) returns true.
+     * @see Quad
+     */
+    fromQuad(original: InQuad): OutQuad;
 }
diff --git a/rdf-js-tests.ts b/rdf-js-tests.ts
index af12b23..121e902 100644
--- a/rdf-js-tests.ts
+++ b/rdf-js-tests.ts
@@ -84,6 +84,21 @@ function test_datafactory() {
 
     const variable: Variable = dataFactory.variable ? dataFactory.variable('v1') : <any> {};
 
+    const defaultGraph: DefaultGraph = dataFactory.defaultGraph();
+
+    const term1: Term = dataFactory.fromTerm(dataFactory.namedNode(""));
+    const term2: Term = dataFactory.fromTerm(dataFactory.blankNode());
+    const term3: Term = dataFactory.fromTerm(dataFactory.literal(""));
+    const term4: Term = dataFactory.fromTerm(dataFactory.variable ? dataFactory.variable("v1") : <any> {});
+    const term5: Term = dataFactory.fromTerm(dataFactory.defaultGraph());
+
+    const quadFromQuad: Term = dataFactory.fromQuad(dataFactory.quad(
+        dataFactory.namedNode("x"),
+        dataFactory.namedNode("y"),
+        dataFactory.literal(""),
+        dataFactory.defaultGraph()
+    ));
+
     const term: NamedNode = <any> {};
     interface QuadBnode extends BaseQuad {
       subject: Term;
@@ -119,6 +134,8 @@ function test_datafactory_star() {
         const equalToSelf: boolean = quadBobAge2.equals(quadBobAge);
         const notEqualToOtherType: boolean = quadBobAge2.equals(dataFactory.namedNode('ex:something:else'));
     }
+
+    const quadTerm: Term = dataFactory.fromTerm(quadBobAge);
 }
 
 function test_datafactory_star_basequad() {
@@ -143,6 +160,10 @@ function test_datafactory_star_basequad() {
         const equalToSelf: boolean = quadBobAge2.equals(quadBobAge);
         const notEqualToOtherType: boolean = quadBobAge2.equals(dataFactory.namedNode('ex:something:else'));
     }
+
+    const baseQuadTerm: Term = dataFactory.fromTerm(quadBobAge);
+
+    const baseQuad: BaseQuad = dataFactory.fromQuad(quadBobAge);
 }
 
 function test_stream() {