Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popover arrow misaligned when class is prefixed #5416

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Fix popover arrow misaligned when class is prefixed #5416

merged 1 commit into from
Sep 8, 2020

Conversation

juangl
Copy link
Contributor

@juangl juangl commented Sep 2, 2020

I'm facing a bug where the popover arrow isn't properly aligned with the overlay target when using prefixed classes. I'm solving the problem in user-space. Just took a moment to create a PR in case that this feels like a proper fix.

Screen Shot 2020-09-01 at 22 01 00

@jquense
Copy link
Member

jquense commented Sep 2, 2020

nice thanks!

@kyletsang
Copy link
Member

Any clean way we can extend this fix for those that pass in bsPrefix directly @jquense?

@jquense
Copy link
Member

jquense commented Sep 2, 2020

Ah, hmm I don't think so. Not neatly anyway.

@kyletsang kyletsang merged commit a0f404a into react-bootstrap:master Sep 8, 2020
@juangl juangl deleted the fix-prefixed-popover-arrow branch September 17, 2020 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants