Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add criteriaMode: all support to class-validator resolver #151

Merged
merged 4 commits into from
Apr 10, 2021

Conversation

jorisre
Copy link
Member

@jorisre jorisre commented Apr 10, 2021

@jorisre
Copy link
Member Author

jorisre commented Apr 10, 2021

@mzalevski Here is the changes, that was not simple to fix nested errors 😅
Can you review this one please ? let me know if I need to change something, thx

@github-actions
Copy link
Contributor

Size Change: -27.1 kB (-69%) 🏆

Total Size: 12 kB

Filename Size Change
class-validator/dist/class-validator.js 478 B -6.79 kB (-93%) 🏆
class-validator/dist/class-validator.modern.js 437 B -6.8 kB (-94%) 🏆
class-validator/dist/class-validator.module.js 499 B -6.76 kB (-93%) 🏆
class-validator/dist/class-validator.umd.js 583 B -6.74 kB (-92%) 🏆
ℹ️ View Unchanged
Filename Size Change
dist/resolvers.js 190 B 0 B
dist/resolvers.modern.js 195 B 0 B
dist/resolvers.module.js 197 B 0 B
dist/resolvers.umd.js 292 B 0 B
joi/dist/joi.js 525 B 0 B
joi/dist/joi.modern.js 419 B 0 B
joi/dist/joi.module.js 540 B 0 B
joi/dist/joi.umd.js 630 B 0 B
superstruct/dist/superstruct.js 269 B 0 B
superstruct/dist/superstruct.modern.js 274 B 0 B
superstruct/dist/superstruct.module.js 282 B 0 B
superstruct/dist/superstruct.umd.js 367 B 0 B
vest/dist/vest.js 419 B 0 B
vest/dist/vest.modern.js 335 B 0 B
vest/dist/vest.module.js 389 B 0 B
vest/dist/vest.umd.js 508 B 0 B
yup/dist/yup.js 541 B 0 B
yup/dist/yup.modern.js 471 B 0 B
yup/dist/yup.module.js 553 B 0 B
yup/dist/yup.umd.js 642 B 0 B
zod/dist/zod.js 470 B 0 B
zod/dist/zod.modern.js 408 B 0 B
zod/dist/zod.module.js 485 B 0 B
zod/dist/zod.umd.js 578 B 0 B

compressed-size-action

Copy link
Contributor

@mzalevski mzalevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bluebill1049
Copy link
Member

Awesome stuff @jorisre The package size reduction is amazing! I will update the doc soon as well. we should tweet this this week. a brand new resolver.

@jorisre
Copy link
Member Author

jorisre commented Apr 10, 2021

Awesome stuff @jorisre The package size reduction is amazing! I will update the doc soon as well. we should tweet this this week. a brand new resolver.

Yeah thanks again to @mzalevski

@jorisre jorisre merged commit 5f806f8 into master Apr 10, 2021
@jorisre jorisre deleted the class-validator-criteria-mode-all branch April 10, 2021 10:36
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants