feat: computed-types resolver #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisre
commented
May 8, 2021
| "birthYear": Object { | ||
| "message": "Expect value to be \\"number\\"", | ||
| "ref": undefined, | ||
| "type": "ValidationError", |
There was a problem hiding this comment.
Always the same type, feel free to suggest a better way
jorisre
commented
May 8, 2021
| path = '', | ||
| ) => { | ||
| return (computedTypesError.errors || []).reduce((acc, error) => { | ||
| const _currentPath = String(error.path[0]); |
There was a problem hiding this comment.
path is always an array of one item
jorisre
commented
May 8, 2021
| } from 'react-hook-form'; | ||
|
|
||
| export type Resolver = ( | ||
| schema: any, |
There was a problem hiding this comment.
Can't find a good way to type the schema.
@kotarella1110 if you want to play with that one, (no worries if you haven't time :))
jorisre
commented
May 8, 2021
| @@ -4,7 +4,7 @@ import type { | |||
| ResolverResult, | |||
| UnpackNestedValue, | |||
| } from 'react-hook-form'; | |||
| import type NopeObject from 'nope-validator/lib/cjs/NopeObject'; | |||
| import type { NopeObject } from 'nope-validator/lib/cjs/NopeObject'; | |||
jorisre
commented
May 8, 2021
| ], | ||
| "publishConfig": { | ||
| "access": "public" | ||
| }, | ||
| "scripts": { | ||
| "prepare": "run-s build:src build && check-export-map", | ||
| "prepare": "run-s build:src build && check-export-map && husky install", |
bluebill1049
approved these changes
May 9, 2021
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to the computed-types resolver ! 🎉
Related to #161
👀 :
asyncmode for that new resolvercriteriaMode: allbecause computed-types returns only the first error of each fieldtype, alwaysValidationError:/ errors don't have a property such as a type, code or a key