Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update for resolvers with new rawValues option #404

Merged
merged 1 commit into from
May 17, 2022

Conversation

bluebill1049
Copy link
Member

@bluebill1049 bluebill1049 commented May 15, 2022

update types for all resolvers

type Options = { 
  mode: 'async' | 'sync',
  rawValues?: boolean 
}
resolver(schema: object, schemaOptions?: object, resolverOptions: Options)

@bluebill1049 bluebill1049 changed the title update for other resolvers with new rawValues option feat: update for resolvers with new rawValues option May 15, 2022
@bluebill1049 bluebill1049 requested a review from jorisre May 15, 2022 09:51
@github-actions
Copy link
Contributor

Size Change: +34 B (0%)

Total Size: 23.3 kB

Filename Size Change
yup/dist/yup.js 629 B +9 B (+1%)
yup/dist/yup.modern.js 569 B +8 B (+1%)
yup/dist/yup.module.js 643 B +9 B (+1%)
yup/dist/yup.umd.js 731 B +8 B (+1%)
ℹ️ View Unchanged
Filename Size
class-validator/dist/class-validator.js 514 B
class-validator/dist/class-validator.modern.js 476 B
class-validator/dist/class-validator.module.js 539 B
class-validator/dist/class-validator.umd.js 617 B
computed-types/dist/computed-types.js 409 B
computed-types/dist/computed-types.modern.js 344 B
computed-types/dist/computed-types.module.js 424 B
computed-types/dist/computed-types.umd.js 503 B
dist/resolvers.js 356 B
dist/resolvers.module.js 369 B
dist/resolvers.umd.js 451 B
io-ts/dist/io-ts.js 1.26 kB
io-ts/dist/io-ts.modern.js 1.1 kB
io-ts/dist/io-ts.module.js 1.14 kB
io-ts/dist/io-ts.umd.js 1.39 kB
joi/dist/joi.js 592 B
joi/dist/joi.modern.js 492 B
joi/dist/joi.module.js 610 B
joi/dist/joi.umd.js 698 B
nope/dist/nope.js 345 B
nope/dist/nope.modern.js 329 B
nope/dist/nope.module.js 365 B
nope/dist/nope.umd.js 434 B
superstruct/dist/superstruct.js 302 B
superstruct/dist/superstruct.modern.js 314 B
superstruct/dist/superstruct.module.js 319 B
superstruct/dist/superstruct.umd.js 404 B
typanion/dist/typanion.js 323 B
typanion/dist/typanion.modern.js 313 B
typanion/dist/typanion.module.js 336 B
typanion/dist/typanion.umd.js 418 B
vest/dist/vest.js 472 B
vest/dist/vest.modern.js 380 B
vest/dist/vest.module.js 436 B
vest/dist/vest.umd.js 562 B
zod/dist/zod.js 572 B
zod/dist/zod.modern.js 522 B
zod/dist/zod.module.js 591 B
zod/dist/zod.umd.js 679 B

compressed-size-action

@jorisre
Copy link
Member

jorisre commented May 16, 2022

Types are updated but for all of the resolvers except zod the new rawValues option isn't used. Maybe we should implement this new feature for all resolver?

@bluebill1049
Copy link
Member Author

Yea, I only updated yup and zod at the moment.

@jorisre jorisre merged commit c560af3 into master May 17, 2022
@jorisre jorisre deleted the keep-rawValues-for-other-resolvers branch May 17, 2022 07:08
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.8.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants