Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typeboxResolver): make TypeBox resolver work with compiled schema #674

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

huynhducduy
Copy link
Contributor

Description

  • Current implementation only makes use of the dynamic validation (aka ValueCheck) of TypeBox but not its TypeCompiler (a high-performance JIT) which is a killer feature, especially when working with recursive or constrained type validation.

Summary of changes

  • Add options for the user to pass a TypeCheck object (returned from TypeCompiler.Compile()) instead of plain schema.
  • Add tests
  • Add document for using TypeCompiler
  • Fix typo in tests of the ValueCheck mode (it mentioned zod instead of typebox)

Copy link
Member

@jorisre jorisre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jorisre jorisre merged commit e8e0f80 into react-hook-form:master Jul 2, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented Jul 5, 2024

🎉 This issue has been resolved in version 3.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants