Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump metro dependencies #210

Closed
belemaire opened this issue Mar 8, 2019 · 1 comment · Fixed by #222
Closed

Bump metro dependencies #210

belemaire opened this issue Mar 8, 2019 · 1 comment · Fixed by #222
Labels
question Further information is requested

Comments

@belemaire
Copy link
Contributor

Would it be possible to bump the version of metro dependencies in next release ?

We're currently evaluating upgrade to RN 59 (using RC 3 as of now) for one of our application, and we faced a new error during bundling. After taking a closer look we realized that we were running into a metro bug, related to assets path resolution, that was fixed in Metro 0.52.0 (facebook/metro@ce6824c).
Manually updated cli metro dependencies locally to give it a try, and bundling issue was gone.

Thanks.
@belemaire belemaire added the question Further information is requested label Mar 8, 2019
@thymikee
Copy link
Member

thymikee commented Mar 9, 2019

Yup we shuold bump it, even though it's possibly breaking change (0.59 is the first public version this CLI is used in). Want to send a PR?

@belemaire belemaire mentioned this issue Mar 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump metro to 0.53 belemaire/react-native-cli
2 participants
@belemaire @thymikee