Fixed Android timezone issues and corresponding e2e test #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
vonovak
reviewed
Jun 2, 2021
luancurti
approved these changes
Jun 2, 2021
|
thank you for the PR! |
vonovak
pushed a commit
that referenced
this pull request
Jun 3, 2021
## [3.5.2](v3.5.1...v3.5.2) (2021-06-03) ### Bug Fixes * resolve timezoneOffsetInMinutes android bugs ([#472](#472)) ([b87a0c4](b87a0c4))
|
🎉 This PR is included in version 3.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found out that the datetime picker uses the device timezone by default and if we use the prop
timezoneOffsetInMinutesthen it uses the utc time. Basically the proptimezoneOffsetInMinuteswas not working. There was already a PR for this fix but it was failing e2e tests and the submitter was not responding since April 10 so I am making this PR in which I have fixed the issue and the e2e tests as well. The PR already made is mentioned below.Related Pull Requests
#431
Test Plan
Display initially passed date (input)
device: GMT +3,app: GMT -7)2021-04-09T17:00:00.000Zdate (for UTC it stands for17:00, but for app timezone-7it should be treated like10:00)timeZoneOffsetInMinutes={-420}prop (-420 = -7 * 60)10:00as initial selected date17:00as initial selected dateAccording to this fact, we can suppose that
timezoneOffsetInMinutesprop is ignored and UTC hours & minutes are displayed instead.What's required for testing (prerequisites)?
GMT -7)device: GMT +3,app: GMT -7)What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist