Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): spinner buttons invisible #673

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Conversation

vonovak
Copy link
Member

@vonovak vonovak commented Oct 15, 2022

Summary

closes #543

Test Plan

tested locally, see screenshots. Also CI should pass

changing button text color would be nice, that can be done in a separate PR

before

old_dark
old_light

after

new_dark
new_light

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@vonovak vonovak merged commit 9b5a631 into master Oct 15, 2022
@vonovak vonovak deleted the fix/invisible-spinner-btns branch October 15, 2022 22:22
vonovak pushed a commit that referenced this pull request Oct 15, 2022
## [6.5.1](v6.5.0...v6.5.1) (2022-10-15)

### Bug Fixes

* **android:** spinner buttons were invisible ([#673](#673)) ([9b5a631](9b5a631))
@vonovak
Copy link
Member Author

vonovak commented Oct 15, 2022

🎉 This issue has been resolved in version 6.5.1 🎉

If this package helps you, consider sponsoring us! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android button text color irregular in Expo managed workflow app
1 participant