Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix podspec to get source from tag #103

Merged
merged 2 commits into from
Feb 2, 2020
Merged

Fix podspec to get source from tag #103

merged 2 commits into from
Feb 2, 2020

Conversation

luancurti
Copy link
Member

@luancurti luancurti commented Feb 1, 2020 •
edited
Loading

Summary

When running pod install get the pods from specific tag of released version

Test Plan

Go to example/ios folder and make pod install open example project in Xcode and the example works without problems

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@vonovak vonovak merged commit b9f1a14 into react-native-datetimepicker:master Feb 2, 2020
@vonovak
Copy link
Member

vonovak commented Feb 2, 2020

good catch, thanks!

@luancurti luancurti deleted the fix/podspec branch February 2, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vonovak vonovak vonovak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luancurti @vonovak