Fix android time picker returning today's date instead of the given date #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 12, 2020 09:19
…create the date object so it doesn't default to returning the current date when using the time picker. Fixes issue react-native-datetimepicker#94
luancurti
requested changes
Feb 12, 2020
luancurti
approved these changes
Feb 13, 2020
|
This issue has not been fixed still. Using the latest v 2.3.0, On setting time, the date still changes to the current date. |
|
same here |
|
@roconnorr - kindly look into this issue again. The issue is still not resolved. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After a time value is chosen in the android picker, use the value prop to create the date object so it doesn't default to returning the current date when using the time picker. Closes #94
Test Plan
What's required for testing (prerequisites)?
A test project for android with a time picker set to
mode="time"What are the steps to reproduce (after prerequisites)?
Pass the time picker a date that is not today, log the value returned from the picker after selecting a time, and see that it returns today's date.
Compatibility
Checklist
README.md- not applicable for bug fixCHANGELOG.mdexample/App.js) - not applicable for bug fix