Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using @react-native-community/eslint-config #3

Merged
merged 2 commits into from
May 23, 2019
Merged

Using @react-native-community/eslint-config #3

merged 2 commits into from
May 23, 2019

Conversation

DanielSanudo
Copy link
Collaborator

@DanielSanudo DanielSanudo commented May 23, 2019 •
edited by Swaagie
Loading

  • Integrating @react-native-community/[email protected]
  • Included test folder for linting
  • Added posttest step for linting

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

Swaagie
Swaagie approved these changes May 23, 2019
View reviewed changes
Copy link
Collaborator

@Swaagie Swaagie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, would be nice if we could just read the .prettierrc from react-native, but it is not bundled with the package.

@DanielSanudo DanielSanudo mentioned this pull request May 23, 2019
Merged
5 tasks
@Swaagie Swaagie merged commit 8a70702 into react-native-datetimepicker:master May 23, 2019
@DanielSanudo DanielSanudo deleted the GX-16937 branch May 24, 2019 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swaagie Swaagie Swaagie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielSanudo @Swaagie @dsanudovacas