Fix Android Nougat datetime picker display="spinner" #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be merged ASAP :) |
vonovak
reviewed
Jan 30, 2020
android/src/main/java/com/reactcommunity/rndatetimepicker/RNDismissableDatePickerDialog.java
Show resolved
Hide resolved
vonovak
approved these changes
Jan 31, 2020
|
thanks @luancurti! Would you be interested in helping to maintain the module? |
|
@vonovak yes. Could you add me as a maintainer? |
|
Sorry this is mistype? |
vonovak
changed the title
|
@FDiskas display="spinner" is correct :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I got it from https://gist.github.com/jeffdgr8/6bc5f990bf0c13a7334ce385d482af9f and
did some adjustments in order to work with DatePicker. Workaround for this bug: https://code.google.com/p/android/issues/detail?id=222208. In Android 7.0 Nougat, spinner mode for the DatePicker in DatePickerDialog is incorrectly displayed as calendar.
Test Plan
Run Example with Android Emulator with Android Nougat (7.0), and modify example setting
mode="spinner"What are the steps to reproduce (after prerequisites)?
Run Example in current
master branchwith Android Emulator with Android Nougat (7.0), and modify example settingmode="spinner"the emulator shows calendarChecklist