Do not require es6 or downlevel-iterators TS flag #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool - I was hoping it was a really small thing like this. Didn't seem like a huge deal but if it widens compatibility for such a small cost, maybe a worthwhile win. LGTM |
react-native-community-bot
pushed a commit
that referenced
this pull request
May 24, 2019
## [3.1.2](v3.1.1...v3.1.2) (2019-05-24) ### Bug Fixes * Do not require es6 or downlevel-iterators TS flag ([#104](#104)) ([f91cdd3](f91cdd3))
|
🎉 This PR is included in version 3.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I AM SO JEALOUS of your CI and semantic-release setup. I really have to get that going for device-info. Thanks @matt-oakes ! |
|
I love that I can release new versions with the push of a button from bed 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a simple fix for #100 which removed the need for
es6or the downlevel-iterators TypeScript flag.Fixes #100.
Test Plan
Tests should pass.
cc @mikehardy