-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: iOS SSID to WiFi details #210
feat: iOS SSID to WiFi details #210
Conversation
👋 Thanks for the PR. I will review this when I have an opportunity to. |
Thanks for this PR. I've taken a look and the requirements for using this API on iOS are pretty complicated. Quoting from the documentation:
For this PR to be merged, I think we need to ensure that the We will also need to update the documentation to make it clear what the requirements are for using this API. Linking to this Apple documentation page is likely enough there: |
Taken from react-native-iot-wifi
Changes introduced |
# [4.6.0](v4.5.0...v4.6.0) (2019-11-03) ### Features * iOS SSID to WiFi details ([#210](#210)) ([119b372](119b372))
🎉 This PR is included in version 4.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Overview
I've added in the
ssid
key to the details object on WiFi connection on iOS.Test Plan
I couldn't test the code on a real iPhone, I do not have access to one at the moment.