feat(Android): Detect and report VPN connections correctly on Android #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-oakes
force-pushed
the
matt-oakes/vpn
branch
from
33864d6
to
61510ec
Compare
|
LGTM |
|
With possible exception that the table of descriptors is a mix of "The active connection is..." and "The active connection ..." (no is). The "The"s are repetitive and the is or not-is variants might be normalized. But this is a doc / wording comment, not functionality. Suggest all have format of "Active connection is over " |
[ci skip]
|
Thanks! I updated the README with your suggestions too. |
react-native-community-bot
pushed a commit
that referenced
this pull request
May 18, 2019
# [3.1.0](v3.0.2...v3.1.0) (2019-05-18) ### Features * **Android:** Detect and report VPN connections correctly on Android ([#95](#95)) ([1f9e5c1](1f9e5c1))
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds the ability to detch VPN connections on Android. These were previously reported as "unknown". I have also added a fallback to "other" if we have a connection, but can't determine the type. This means we can handle new types being added without the user being reported incorrectly as "offline".
Fixes #87.
Test Plan
Tested on multiple Android devices with a VPN client.