fix(Android): Send a "none" status if the device has no active network on launch #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any ideas if this will also fix #64 ? My guess is that this will fix it if the app wasn't already running (i.e., a full JS VM start for the headless process), but it will report an "outdated" value if the app was already running. I wonder if the update and send call can be exposed to the JS somehow in order to force the event to fire for such cases. |
|
Potentially, however, I've not been able to look into that one as there's no easily reproducible demo for it. If you can test it with this patch then that would be very useful 👍 |
|
LGTM |
react-native-community-bot
pushed a commit
that referenced
this pull request
May 18, 2019
## [3.0.2](v3.0.1...v3.0.2) (2019-05-18) ### Bug Fixes * **android:** Send a "none" status if the device has no active network on launch ([#96](#96)) ([c62cd8b](c62cd8b))
|
🎉 This PR is included in version 3.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If a subscription to the network state was made on Android N+ when there was no active network, none of the callbacks would get called. Therefore, the state would be incorrectly reported as "unknown".
This PR adds a check if no active network on register and then manually calls
updateAndSend()to emit thenonestate.Fixes #77
Test Plan
Tested on a Pixel 2 in various states.