0.59.8 Discussion

[grabbou]

Conversation on this thread are limited to 0.59.8 release's major issues and cherry-pick requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59.7 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.59-stable branch yourself, in order to ensure that the process proceeds smoothly.

[grabbou]

We need to cherry-pick this commit: #118 (comment)

[grabbou]

Published as 0.59.8. Didn't cherry-pick #124 (comment) because it depends on another commit and it can't be applied easily.

I also didn't cherry-pick the "Fix accessibility event properties for TextInput" (0a3bbc by @elucaswork)) because it breaks Detox tests. Waiting for someone to help me debug this.

[kelset]

If we can, we should try to cherry pick this: facebook/react-native@30348f7

it seems that Gradle 3.4.0 causes crashes in the current RN version.

[kelset]

Also, this should help (if it wasn't cherry picked already) facebook/react-native@8f186b8

[jinshin1013]

Can we also cherry pick this if it's not too late?:

• [iOS] Fixes tintColor not changing on Gif image on iOS facebook/react-native@75380aa

[cihati]

@grabbou any news on when this will be released?

[kelset]

👋
given that at the moment there are only, like, 4 commits requested I wanted to wait a bit more before doing a new release. But I feel that I may have some time to tackle this later this week or next week.

[kelset]

Other commit to cherry pick: facebook/react-native@c87de76

and facebook/react-native#25098 if and when it lands

[kelset]

Last commit (likely): facebook/react-native@d8fa120

[kelset]

Also, if it works, this would be great: facebook/react-native@46c7ada

[kelset]

Hey everyone, I tried to cherry-pick the commits and this is what I ended up with:

• couldn't cherry pick facebook/react-native@20b4879 & facebook/react-native@75380aa & facebook/react-native@0a3bbcd1b2c (detox fails)

• this was already on branch facebook/react-native@c87de76

• you can find the list of the commits cherry picked here: https://github.com/facebook/react-native/commits/0.59-stable

I've done quite some testing and I'm fairly sure that upgrading to this won't require you to do any change in your code (but it will support up to Gradle 5.4.1 & Gradle Tools 3.4.0 & Xcode 11).

I'm waiting now for the last commit I had to cherry pick to go green then I'll do the bump commit.

[kelset]

Ok, 0.59.9 is out - and upgrading is as simple as changing the version number.

I'll now create the changelog & the release & the tweet & the new issue for next 0.59.x.

[kelset]

Closing in favour of #127