-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PodFile Multiple targets break Flipper support #55
Comments
@TheSolly I have moved your issue from |
@lucasbento Done, thanks 🙏 |
@TheSolly I put the |
@lucasbento Exactly, although this is my proposed solution. Am sure open to improvement. |
@TheSolly cool! cc @priteshrnandgaonkar & @alloy, any thoughts on this? |
Technically, I think the If your targets share the same set of pods, I would recommend defining a method to "share" the pod list:
|
What @matt-oakes said. Also note that CocoaPods has the notion of a ‘abstract target’ to share pods, but either solution will work for most cases. |
Thanks for info, applied @matt-oakes methodology and everything is working smoothly 🙏 |
I didn’t know about abstract targets. Good to know! I don’t think it needs to be covered in the upgrade helper as it’s a bit more “advanced” than most users will need. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks |
Environment
Upgrading version
from=0.61.5 --> to=0.62.2
Description
I am Having multiple target in the PodFile, and according to the upgrade helper process i should put this code inside the my target for Flipper.
Trying to add the same piece of code into my other target Prod like this:
When running
pod install
i got the following error:According to this issue 6172 CocoaPods doesn't support multiple
post_install
hooks.To solve this issue, i had to rewrite the code as below:
So far both my target build successfully in debug mode with flipper support.
IMO, this should be the default way to insert the
post-install
hook for Flipper in the upgrade helper.The text was updated successfully, but these errors were encountered: