Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for timezoneOffsetInMinutes in Android #284

Closed
StarryFire opened this issue Sep 21, 2020 · 7 comments
Closed

Support for timezoneOffsetInMinutes in Android #284

StarryFire opened this issue Sep 21, 2020 · 7 comments
Labels
good first issue Good for newcomers

Comments

@StarryFire
Copy link

Feature request

Why it is needed

Our app uses in-app timezone rather than the device's timezone. So we need to set the timezone offset in datetime pickers in android like we do for iOS datetime pickers.

Code sample

<DateTimePicker
     ...
     timezoneOffsetInMinutes={30}
    ...
/>
@Quelu
Copy link

Quelu commented Dec 18, 2020

Hello @StarryFire
Did you find any solution or workaround for this?

@StarryFire
Copy link
Author

@Quelu Yup, i started using this library instead https://github.com/henninghall/react-native-date-picker

@vonovak vonovak added the good first issue Good for newcomers label Jan 25, 2021
@billnbell
Copy link
Collaborator

This is fixed. Can we lok at merging, or give me some feedback?

https://github.com/billnbell/datetimepicker

@bobdepreziz
Copy link

This is still not working at my end. Any value I specify in timeZoneOffsetInMinutes results in the same offset, it is not working as expected. Can someone verify? I tried it with this package: https://github.com/henninghall/react-native-date-picker, there it works fine.

Thanks

@abhittal
Copy link

abhittal commented May 6, 2021

@bobdepreziz It's not working at my end as well. I tried specifying many values in timeZoneOffsetInMinutes but always get the UTC time in the time picker. Can you suggest me how can I select time relative to my device's timezone?

@tanjoash
Copy link

tanjoash commented May 18, 2021

@bobdepreziz It's not working at my end as well. I tried specifying many values in timeZoneOffsetInMinutes but always get the UTC time in the time picker. Can you suggest me how can I select time relative to my device's timezone?

Looking for a solution to this as well. Not a big issue but isn't very pleasant. haha! seems to be a known issue as seen here #431. Just be patient for a fix and happy coding!

@vonovak
Copy link
Member

vonovak commented Jan 8, 2022

closing as this is implemented, see in readme. There are some bugs, but it's pointless for this to remain open.

@vonovak vonovak closed this as completed Jan 8, 2022
@react-native-datetimepicker react-native-datetimepicker locked and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

7 participants