Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to prevent pushing a screen twice when tapped quickly #42

Closed
brentvatne opened this issue Feb 9, 2018 · 4 comments
Closed

How to prevent pushing a screen twice when tapped quickly #42

brentvatne opened this issue Feb 9, 2018 · 4 comments

Comments

@brentvatne
Copy link
Member

I think we need to still do more thinking about the right way to handle this in the library. Blocking a second action is wrong (hard to understand when you actually want to do this why it didn't work) and our current solution of using idempotent pushes (provide a key) isn't as ergonomic as it could be.

@vonovak
Copy link
Member

vonovak commented Oct 1, 2018

this is no longer an issue in v2, imho (key is not needed), so closing.

@vonovak vonovak closed this as completed Oct 1, 2018
@iamclaytonray
Copy link

iamclaytonray commented Sep 8, 2019

@brentvatne @vonovak - could you provide a reason as to why this is not an issue any longer, or a workaround? I still have this issue using the latest as of today. Thanks!

@vonovak
Copy link
Member

vonovak commented Sep 8, 2019

@iamclaytonray please open a new issue with a repro if you're hitting an issue, thanks.

@react-navigation react-navigation locked and limited conversation to collaborators Sep 8, 2019
@brentvatne
Copy link
Member Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants