Fix #361 cancel timer when tabs component unmounts

react-toolbox · Mar 16, 2016 · 380da26 · 380da26
1 parent 752f2cb
commit 380da26
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/components/tabs/Tabs.jsx b/components/tabs/Tabs.jsx
@@ -27,6 +27,10 @@ class Tabs extends React.Component {
     this.updatePointer(nextProps.index);
   }
 
+  componentWillUnmount () {
+    clearTimeout(this.pointerTimeout);
+  }
+
   handleHeaderClick = (idx) => {
     if (this.props.onChange) this.props.onChange(idx);
   };
@@ -50,7 +54,8 @@ class Tabs extends React.Component {
   }
 
   updatePointer (idx) {
-    setTimeout(() => {
+    clearTimeout(this.pointerTimeout);
+    this.pointerTimeout = setTimeout(() => {
       const startPoint = this.refs.tabs.getBoundingClientRect().left;
       const label = this.refs.navigation.children[idx].getBoundingClientRect();
       this.setState({