feat: Add TextField component #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
cassytaylor
suggested changes
Jan 28, 2020
There was a problem hiding this comment.
Looking good, Mike!! Thanks for jumping on this so quick yesterday! One super small thing I noticed - it looks like the help text is styled the same as the label text (or at least, it's the same color) - we have it styled a little lighter in the mocks as black-55/#737373 to create hierarchy between the label/help text. but other than that it looks great!!
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
|
Deploy preview for heuristic-perlman-0ef024 ready! Built with commit 64761d1 https://deploy-preview-143--heuristic-perlman-0ef024.netlify.com |
cassytaylor
approved these changes
Jan 28, 2020
|
🎉 This PR is included in version 1.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #140
Impact: minor
Type: feature
Component
This is a drop-in replacement for the standard MUI TextField component that defaults to the outlined style. Styles have been updated to match the Catalyst spec, otherwise, it's a standard MUI TextField under the hood.
This gives us all of its features including
Screenshots
Breaking changes
none
Testing