Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React variables are visible #309

Closed
2 tasks
tanzeelazad95 opened this issue Aug 12, 2020 · 5 comments · Fixed by #341
Closed
2 tasks

React variables are visible #309

tanzeelazad95 opened this issue Aug 12, 2020 · 5 comments · Fixed by #341
Assignees
Labels
bug For issues that describe a defect or regression in the released software core work For issues that track feature development work being done by core Reaction developers verified reproducible For issues that describe bugs that the core team was able to confirm

Comments

@tanzeelazad95
Copy link

We have followed the Reaction Development Platform to install Reaction.

Prerequisites

  • Are you running the latest version?
  • Are you able to consistently reproduce the issue?

Issue Description

"The labels aren't loading all the time, it displays React variables. The issue exists in Chrome, firefox
and safari."
Screenshot

Steps to Reproduce

  1. Login to reaction
  2. Navigate the pages
  3. Refresh the page

You will see that react variables are showing instead of labels.

Possible Solution

The labels should be shown on refreshing the page instead of react variables

System information

  • MAC OS Catalina
  • Ubuntu 20.04 LTS
@kieckhafer
Copy link
Member

Thanks for the reported issue, @tanzeelazad95.

The reaction-development-platform repository is used to bootstrap the project and get it up and running, but issues regarding the API, Admin, Storefront, or anything outside the initial build are better suited in their respective project repositories.

I'm going to move this issue to the reaction-admin repo.

@kieckhafer kieckhafer transferred this issue from reactioncommerce/reaction-development-platform Aug 21, 2020
@kieckhafer
Copy link
Member

Hi @tanzeelazad95, what you are seeing are actually the translations keys, not React variables.

I am not able to reproduce:
image

Be sure you have at least english translations available with those keys.

@ghost
Copy link

ghost commented Sep 5, 2020

I'm able to reproduce this issue by opening beta.7 or beta.9 and refreshing the page after clicking Orders:

Screen Shot 2020-09-05 at 09 14 34

It's a duplicate of #310 as both are caused due to a race condition/missing suspense for translation text.

@mian-muhammad
Copy link

@kieckhafer I am also able to reproduce it in reaction-admin v3.0.0-beta.8
Screenshot from 2020-09-08 09-45-56

@brent-hoover
Copy link
Collaborator

fwiw I also see this issue when running this on the latest tip of reaction-admin. Sometimes it render correctly, sometimes not. Refreshing a few times usually works around it, but it seems to be clearly a race condition issue. (there are a ton of these in the latest admin)

@nnnnat nnnnat added core work For issues that track feature development work being done by core Reaction developers needs triage For issues that are awaiting triage by the core development team labels Jan 19, 2021
@Akarshit Akarshit added bug For issues that describe a defect or regression in the released software verified reproducible For issues that describe bugs that the core team was able to confirm and removed needs triage For issues that are awaiting triage by the core development team labels Jan 20, 2021
@Akarshit Akarshit self-assigned this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software core work For issues that track feature development work being done by core Reaction developers verified reproducible For issues that describe bugs that the core team was able to confirm
Projects
None yet
6 participants