Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing languages from English to Romanian and back again only changes some labels #1476

Closed
brent-hoover opened this issue Oct 6, 2016 · 1 comment

Comments

@brent-hoover
Copy link
Collaborator

Expected behavior

All labels for which there is a translation should show Romanian when that language is selected and go back to English when English is selected

Actual Behavior

Some labels switch back, some do not.

Steps to Reproduce the Behavior

  1. Login to edit product
  2. Switch language to Romanian
  3. Observe that most labels have switched to Romanian
  4. Switch language back to English
  5. Observe that some labels do not switch back to English
  6. Refresh page and observe that all labels switch back to English

This is an edge case since I don't know how often people would need to change languages while editing products and even then you can just refresh to fix it, but just documenting it here.

@aaronjudd
Copy link
Contributor

This is usually caused by:
1 - missing translations phrases
2 - missing i18n implementations

and is not generally language specific.

I am closing, as we've now translated most missing phrases for all our top languages.

I'm not able to replicate behaviour specific to switching languages or login/logout. All that is persistent for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants