Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create content menu persists after focus is lost. #1598

Closed
Redmega opened this issue Dec 2, 2016 · 3 comments
Closed

Create content menu persists after focus is lost. #1598

Redmega opened this issue Dec 2, 2016 · 3 comments
Assignees
Labels
verified reproducible For issues that describe bugs that the core team was able to confirm
Milestone

Comments

@Redmega
Copy link

Redmega commented Dec 2, 2016

Expected behavior

On focus loss, add menu should disappear.

Actual Behavior

On focus loss, menu persists. Seems to be two separate menus for the responsive design, i can open it on fullscreen and then make the window smaller to make the menu hide, but when i maximize again it reappears. If i open the menu when the window is small, and then maximize, the same behavior occurs in reverse. If i open it in both the menu never goes away.

screen shot 2016-12-02 at 11 06 58 am

Steps to Reproduce the Behavior

Click on the "+" button (Create Content). Click anywhere else. Resize screen.

For enhancements or other issues, please describe in as much detail as
possible how the app should be changed and how this would benefit
users/developers

Bad UX to not have the create content menu disappear.


If someone can point me to where that code is I can investigate. I'm just starting to hack on this framework so I'm not familiar with where everything is yet.

@Redmega
Copy link
Author

Redmega commented Dec 2, 2016

I tried changing /imports/plugins/core/layout/client/templates/layout/admin/admin.js#L64

instance.dropInstance.open();

to

instance.dropInstance.toggle();

as per the Drop docs, but that didn't seem to work. Are any core drop functionalities being overwritten anywhere?

@aaronjudd
Copy link
Contributor

I think we're going to remove that UI element anyways, originally we thought we'd add additional creation options (create content, product,etc), but we're working on some new UI updates here and this is something that just doesn't feel "right".

@aaronjudd aaronjudd added UIX verified reproducible For issues that describe bugs that the core team was able to confirm labels Dec 5, 2016
@aaronjudd aaronjudd added this to the v0.19.0 milestone Dec 5, 2016
@alexsuslov
Copy link

2 sec. auto hide ?
setTimeout(() => instance.dropInstance.remove(), 2 * 1000 );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified reproducible For issues that describe bugs that the core team was able to confirm
Projects
None yet
Development

No branches or pull requests

5 participants