Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tax-specfic fields to Accounts management screen #1860

Closed
brent-hoover opened this issue Feb 17, 2017 · 9 comments
Closed

Add new tax-specfic fields to Accounts management screen #1860

brent-hoover opened this issue Feb 17, 2017 · 9 comments
Assignees
Milestone

Comments

@brent-hoover
Copy link
Collaborator

brent-hoover commented Feb 17, 2017

Related to #1793

Making this a separate issue since I don't see exactly where this could go as "Manage Accounts" is pretty much just setting permissions.

We need these new fields under accounts:

  • Exemption Code (we have a code here rather than a tax exempt boolean)
  • Entity/Use Code (see this page for a list of standard code, but customers can also create custom code and input their own,.

When these are entered, they need to be passed in along with the cart/order so that the tax amount is reflected correctly.

Additionally the Account ID needs to be displayed and identified.

@brent-hoover brent-hoover added this to the v0.20.0 milestone Feb 17, 2017
@brent-hoover brent-hoover changed the title Add "Tax Exempt" field to Accounts management screen Add new tax-specfic fields to Accounts management screen Feb 20, 2017
@brent-hoover
Copy link
Collaborator Author

There is a problem with this. I did this:

  1. Added a customer use type on one customer (my default admin account) and then did an order and it was reported properly.
  2. Added another customer

This customer does not display properly and when I submitted an order, that order also used the Customer Use Type from the first account which improperly reported it as Tax Exempt

cart_completed

Also I am also getting a few hundred of this error:

cart_completed

This is blocking me from completing the audit

@impactmass
Copy link
Contributor

Thanks @zenweasel. I'll look into these right away.

To clarify what was said and things to be done:

  • Tax Settings should be set at the customer level
  • Should the tax settings form be moved to the view seen when the "Manage" button in front of each account is clicked?

@brent-hoover
Copy link
Collaborator Author

It's not matter of where they show up, but that they only show up for one customer.

@brent-hoover
Copy link
Collaborator Author

In other words, it seems like the "Tax Settings" screen only shows once for all customers rather than for each customer.

@impactmass
Copy link
Contributor

Okay. Got it.

@impactmass
Copy link
Contributor

I've resolved the above issues. It's on the main brent-seun-avalara-taxcompliance-1793 branch.

The only pending part left is a design modification (this can up after my checkin with Ryan).

Design Feedback:

  • Instead of having the form under each user account, show the form in the sidebar that slidesout when the "Manage" button is clicked.

@impactmass
Copy link
Contributor

This is now moved to the "Manage" section. It also now works with all accounts (newly added and old).
I need a review on the approach I took: 6c389a5

@impactmass
Copy link
Contributor

Resolved in #1793

@brent-hoover
Copy link
Collaborator Author

This has been completed.

@ghost ghost assigned brent-hoover Mar 13, 2017
@ghost ghost removed the in progress label Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants