Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update login views to react #2055

Closed
mikemurray opened this issue Mar 28, 2017 · 6 comments
Closed

Update login views to react #2055

mikemurray opened this issue Mar 28, 2017 · 6 comments
Assignees

Comments

@mikemurray
Copy link
Member

mikemurray commented Mar 28, 2017

Part of #2040 and takes care of part of Checkout and Navigation bar


Login views to be converted to react

Things it must do:

  • Work as well as it does now
  • Defaults to sign in for dropdown / 404 page
  • Defaults to register for checkout page
  • Hopefully clean up some of the logic by moving to react. ( This is an OLD OLD OLD blaze component, so it uses some old techniques )

Some views to be converted

  • Sign in, including (password, google, facebook, twitter)
  • Register, including (password, google, facebook, twitter)
  • Reset password
  • The modal that pop up when using a verification email. ( you can get this when you invite a user from the accounts admin )

Places it's used

@mikemurray mikemurray added the UIX label Mar 28, 2017
@mikemurray mikemurray added this to the Next milestone Mar 28, 2017
@mikemurray mikemurray modified the milestones: v1.3.x, Next Apr 4, 2017
@aaronjudd aaronjudd modified the milestones: v1.3.x, React UI Components Apr 25, 2017
@mikemurray mikemurray modified the milestones: React UI Components, React - Navigation Bar May 2, 2017
@aaronjudd aaronjudd removed the ready label May 2, 2017
@kieha kieha self-assigned this May 3, 2017
@kieha
Copy link
Contributor

kieha commented May 4, 2017

Notes:

  • Branch: kieha-login-views-to-react-2055
  • Starting with converting the sign in page client/modules/accounts/templates/signIn

@kieha
Copy link
Contributor

kieha commented May 11, 2017

Update:

  • Finished sign in and sign up conversion
  • Working on reset password

@kieha
Copy link
Contributor

kieha commented May 15, 2017

Update:

  • Sign in/sign up/reset password forms all done
  • Working on modal that pops up when resetPaswordLink/registerLink sent in email is clicked

@kieha
Copy link
Contributor

kieha commented May 15, 2017

Notes

  • For some reason, the onClick call on the Register/Sign In/ResetPassword/Social Login links/buttons doesn't work. Currently looking into it. I've used onDoubleClick on them instead.

@kieha
Copy link
Contributor

kieha commented May 16, 2017

Update:

  • Solved the onClick problem: it now works. Work on this ticket is done.

@kieha
Copy link
Contributor

kieha commented Jun 9, 2017

Closed via #2306

@kieha kieha closed this as completed Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants