Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: createPDF argument mismatch #208

Closed
evliu opened this issue Nov 19, 2014 · 3 comments
Closed

Bug: createPDF argument mismatch #208

evliu opened this issue Nov 19, 2014 · 3 comments

Comments

@evliu
Copy link
Contributor

evliu commented Nov 19, 2014

I've spent a bit of time debugging this one. When createPDF gets called in workflow.coffee:46, it passes the path and orderId, but when I look at the method in methods.coffee:70, it also requires a token (something to do with a hash token or something for phantomJS), and fails line 73 when it's validated check(token, String)

Any ideas?

@aaronjudd
Copy link
Contributor

There's a nice long issue here: #52

I think we should just get rid of phantom, it's a lot of overhead for limited functionality

@aaronjudd
Copy link
Contributor

My suggestion is we replace with Blaze.toHTMLWithData + https://github.com/MrRio/jsPDF to create PDFs.

@evliu
Copy link
Contributor Author

evliu commented Nov 19, 2014

Ahh got it, I'll close this ticket in lieu of that one. For now, I'll just remove the createPDF method call from the order creation on my local [:

@evliu evliu closed this as completed Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants