Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to React Router #2099

Closed
mikemurray opened this issue Apr 10, 2017 · 1 comment
Closed

Convert to React Router #2099

mikemurray opened this issue Apr 10, 2017 · 1 comment
Assignees
@mikemurray
Labels
epic For issues that exist only to track progress on a list of other issues in one place
Milestone
React Router

Comments

@mikemurray
Copy link
Member

Part of #2040 and takes care of part of Router
Related to #2049

Convert from FlowRouter to React Router.

Things it must do:

  • Must not be a breaking change for those that used the registry to populate their custom routes.
  • Must render a react layout, which means the main app layout needs to be wrapped inside a react component at least.

This will be a breaking change for those that may have defined routes by means other than the Reaction Registry.
@mikemurray mikemurray added this to the v1.3.x milestone Apr 10, 2017
@mikemurray mikemurray self-assigned this Apr 10, 2017
@mikemurray mikemurray mentioned this issue Apr 13, 2017
Merged
@aaronjudd aaronjudd modified the milestones: v1.3.x, React UI Components Apr 25, 2017
@aaronjudd
Copy link
Contributor

Some other items to consider are documented in #1394

@aaronjudd aaronjudd added the epic For issues that exist only to track progress on a list of other issues in one place label Apr 26, 2017
@aaronjudd aaronjudd modified the milestones: React Router, React UI Components Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikemurray mikemurray

Labels
epic For issues that exist only to track progress on a list of other issues in one place
Projects
None yet
Milestone
React Router
Development

No branches or pull requests
2 participants
@mikemurray @aaronjudd