Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception in delivering result of invoking 'email/verifySettings' #2464

Closed
aaronjudd opened this issue Jun 19, 2017 · 7 comments
Closed

Exception in delivering result of invoking 'email/verifySettings' #2464

aaronjudd opened this issue Jun 19, 2017 · 7 comments
Assignees
Labels
bug For issues that describe a defect or regression in the released software

Comments

@aaronjudd
Copy link
Contributor

aaronjudd commented Jun 19, 2017

Open email settings in dashboard, update settings, close the dashboard panel, view browser console:

    at onData (http://localhost:3000/packages/modules.js?hash=324c20e0822d5dd5972b7d40d96a63c0b55798e8:18970:21)
    at http://localhost:3000/app/app.js?hash=35ec44c0610a5ab62f80750be4a4e4201baed3fd:72691:18
    at MethodInvoker._callback (http://localhost:3000/packages/meteor.js?hash=27829e936d09beae3149ecfbf3332c42ccb1596f:1105:22)
    at MethodInvoker._maybeInvokeCallback (http://localhost:3000/packages/ddp-client.js?hash=c9ca22092a3137a7096e8ab722ba5ab8eedb9aec:3678:12)
    at MethodInvoker.receiveResult (http://localhost:3000/packages/ddp-client.js?hash=c9ca22092a3137a7096e8ab722ba5ab8eedb9aec:3698:10)
    at Connection._livedata_result (http://localhost:3000/packages/ddp-client.js?hash=c9ca22092a3137a7096e8ab722ba5ab8eedb9aec:4816:9)
    at onMessage (http://localhost:3000/packages/ddp-client.js?hash=c9ca22092a3137a7096e8ab722ba5ab8eedb9aec:3525:206)
    at http://localhost:3000/packages/ddp-client.js?hash=c9ca22092a3137a7096e8ab722ba5ab8eedb9aec:2908:9
    at Array.forEach (native)
    at Function._.each._.forEach (http://localhost:3000/packages/underscore.js?hash=cde485f60699ff9aced3305f70189e39c665183c:149:11)

Node: 7.5.0
NPM: 5.0.0
Meteor Node: 4.8.3
Meteor NPM: 4.6.1
Reaction CLI: 0.10.0
Reaction: 1.3.0
Reaction branch: updated-packages-1.3.1
Docker: 17.03.1-ce

@aaronjudd aaronjudd added the bug For issues that describe a defect or regression in the released software label Jun 19, 2017
@kieckhafer
Copy link
Member

kieckhafer commented Jun 19, 2017

Settings do not even need to be updated. If you open the email settings, then close the panel immediately, it will still show the error.

I've narrowed this down to the component re-rendering when we close the side-panel, and our Meteor.call here sending data back as the component is unmounted. I'm not sure why it's re-rendering...

There are similar issues in the react-komposer github issues list, I've left a comment on an issue to see if there has been a solution found.

@brent-hoover
Copy link
Collaborator

Assigning to @kieckhafer as he seems to understand the issue. Sorry dude.

@kieckhafer
Copy link
Member

I believe I fixed this in pr #2416, @zenweasel can you confirm?

@brent-hoover
Copy link
Collaborator

@kieckhafer No, still happening.

@brent-hoover
Copy link
Collaborator

@kieckhafer Let me assign this to someone else.

@desaawa
Copy link
Contributor

desaawa commented Jul 5, 2017

@kieckhafer I also confirmed this to be caused by react-komposer. It calls the method when the component is unmounting, which tries to set the data for the component after it has unmounted already.
Please check if the fix here can be okay for now, while we wait for a fix from react-komposer

@desaawa desaawa closed this as completed Jul 7, 2017
@desaawa
Copy link
Contributor

desaawa commented Jul 7, 2017

Closed via #2512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

No branches or pull requests

4 participants